// ConnectionConfigDialog.cpp — modal connection editor for the Data Sources // screen. Self-contained: builds its own form, validates, saves, and returns // the resulting connection ID. #include "screens/data_sources/ConnectionConfigDialog.h" #include "screens/data_sources/DataSourcesHelpers.h" #include "storage/repositories/DataSourceRepository.h" #include "ui/theme/Theme.h" #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include namespace fincept::screens::datasources { namespace col = fincept::ui::colors; QString show_connection_config_dialog(QWidget* parent, const ConnectorConfig& config, const QString& edit_id, bool duplicate) { const bool editing = !edit_id.isEmpty() && !duplicate; DataSource existing; QJsonObject existing_cfg; bool existing_loaded = false; if (!edit_id.isEmpty()) { auto result = DataSourceRepository::instance().get(edit_id); if (result.is_ok()) { existing = result.value(); existing_cfg = QJsonDocument::fromJson(existing.config.toUtf8()).object(); existing_loaded = true; } } QString saved_id; QDialog dlg(parent); dlg.setWindowTitle(editing ? QObject::tr("Edit — %1").arg(config.name) : duplicate ? QObject::tr("Clone — %1").arg(config.name) : QObject::tr("Configure — %1").arg(config.name)); dlg.resize(560, 620); dlg.setModal(true); dlg.setStyleSheet( QString("QDialog { background:%1; color:%2; }" "QLabel { color:%3; font-size:12px; background:transparent; font-family:'Consolas','Courier " "New',monospace; }" "QLineEdit, QTextEdit, QComboBox { background:%4; border:1px solid %5; color:%2;" " padding:6px 10px; font-size:13px; font-family:'Consolas','Courier New',monospace; }" "QLineEdit:focus, QTextEdit:focus, QComboBox:focus { border-color:%6; }" "QCheckBox { color:%2; font-size:13px; font-family:'Consolas','Courier New',monospace; }" "QPushButton { padding:7px 18px; font-size:12px; font-weight:700;" " font-family:'Consolas','Courier New',monospace; }") .arg(col::BG_SURFACE(), col::TEXT_PRIMARY(), col::TEXT_SECONDARY(), col::BG_BASE(), col::BORDER_DIM(), col::AMBER())); auto* root_vl = new QVBoxLayout(&dlg); root_vl->setContentsMargins(0, 0, 0, 0); root_vl->setSpacing(0); // Dialog header auto* dlg_hdr = new QWidget(&dlg); dlg_hdr->setFixedHeight(56); dlg_hdr->setStyleSheet( QString("background:%1;border-bottom:1px solid %2;").arg(col::BG_RAISED(), col::BORDER_DIM())); auto* dlg_hdr_hl = new QHBoxLayout(dlg_hdr); dlg_hdr_hl->setContentsMargins(16, 0, 16, 0); dlg_hdr_hl->setSpacing(12); auto* code_lbl = new QLabel(connector_code(config)); code_lbl->setAlignment(Qt::AlignCenter); code_lbl->setFixedSize(36, 36); code_lbl->setStyleSheet(QString("background:%1;color:%2;border:1px solid %3;font-size:14px;font-weight:700;") .arg(config.color, col::TEXT_PRIMARY(), col::BORDER_DIM())); dlg_hdr_hl->addWidget(code_lbl); auto* title_vl = new QVBoxLayout; title_vl->setContentsMargins(0, 0, 0, 0); title_vl->setSpacing(2); auto* dlg_title = new QLabel(editing ? QObject::tr("Edit %1").arg(config.name) : duplicate ? QObject::tr("Clone %1").arg(config.name) : config.name); dlg_title->setStyleSheet( QString("color:%1;font-size:14px;font-weight:700;background:transparent;").arg(col::AMBER())); title_vl->addWidget(dlg_title); auto* dlg_sub = new QLabel(config.description); dlg_sub->setWordWrap(true); dlg_sub->setStyleSheet(QString("color:%1;font-size:11px;background:transparent;").arg(col::TEXT_SECONDARY())); title_vl->addWidget(dlg_sub); dlg_hdr_hl->addLayout(title_vl, 1); root_vl->addWidget(dlg_hdr); // Scrollable form body auto* scroll = new QScrollArea; scroll->setWidgetResizable(true); scroll->setFrameShape(QFrame::NoFrame); scroll->setStyleSheet(QString("QScrollArea { background:%1; border:none; }").arg(col::BG_SURFACE())); auto* body = new QWidget(&dlg); auto* body_vl = new QVBoxLayout(body); body_vl->setContentsMargins(20, 20, 20, 20); body_vl->setSpacing(16); auto* form = new QGridLayout; form->setHorizontalSpacing(14); form->setVerticalSpacing(10); form->setColumnStretch(1, 1); form->setColumnMinimumWidth(0, 130); int row = 0; auto* name_lbl = new QLabel(QObject::tr("Connection Name")); name_lbl->setAlignment(Qt::AlignRight | Qt::AlignVCenter); form->addWidget(name_lbl, row, 0); auto* name_edit = new QLineEdit; name_edit->setPlaceholderText(QObject::tr("%1 Connection").arg(config.name)); name_edit->setText(existing_loaded ? (duplicate ? QObject::tr("Copy of %1").arg(existing.display_name) : existing.display_name) : ""); name_edit->setFixedHeight(34); name_edit->setAccessibleName(QObject::tr("Connection name")); name_edit->setAccessibleDescription(QObject::tr("Display name for this %1 connection").arg(config.name)); form->addWidget(name_edit, row, 1); name_lbl->setBuddy(name_edit); ++row; auto* enabled_lbl = new QLabel(QObject::tr("Enable Connection")); enabled_lbl->setAlignment(Qt::AlignRight | Qt::AlignVCenter); form->addWidget(enabled_lbl, row, 0); auto* enabled_check = new QCheckBox(QObject::tr("Active")); enabled_check->setChecked(existing_loaded ? existing.enabled : true); enabled_check->setAccessibleName(QObject::tr("Enable connection")); form->addWidget(enabled_check, row, 1); ++row; QMap field_widgets; // Focus chain in visual order — the dialog previously relied on creation // order, which put the footer buttons ahead of the dynamic form fields. QVector focus_chain{name_edit, enabled_check}; bool has_secret_field = false; for (const auto& field : config.fields) { auto* lbl = new QLabel(field.label + (field.required ? " *" : "")); lbl->setAlignment(Qt::AlignRight | Qt::AlignVCenter); form->addWidget(lbl, row, 0); QWidget* input = nullptr; if (field.type == FieldType::Checkbox) { auto* check = new QCheckBox(field.required ? QObject::tr("Required") : QObject::tr("Optional")); const bool value = existing_cfg.contains(field.name) ? existing_cfg.value(field.name).toBool() : (field.default_value == "true"); check->setChecked(value); input = check; } else if (field.type == FieldType::Select) { auto* combo = new QComboBox; for (const auto& option : field.options) combo->addItem(option.label, option.value); const QString current = existing_cfg.contains(field.name) ? existing_cfg.value(field.name).toString() : field.default_value; const int index = combo->findData(current); if (index >= 0) combo->setCurrentIndex(index); input = combo; } else if (field.type == FieldType::Textarea) { auto* edit = new QTextEdit; edit->setMaximumHeight(90); edit->setPlaceholderText(field.placeholder); edit->setPlainText(existing_cfg.contains(field.name) ? existing_cfg.value(field.name).toString() : field.default_value); input = edit; } else { auto* edit = new QLineEdit; edit->setPlaceholderText(field.placeholder); edit->setFixedHeight(34); if (field.type == FieldType::Password) edit->setEchoMode(QLineEdit::Password); if (field.type == FieldType::Number) edit->setValidator(new QIntValidator(0, 999999999, edit)); const QString text = existing_cfg.contains(field.name) ? existing_cfg.value(field.name).toVariant().toString() : field.default_value; edit->setText(text); input = edit; } if (field.type == FieldType::Password) { has_secret_field = true; input->setAccessibleName(QObject::tr("%1 (secret)").arg(field.label)); input->setAccessibleDescription( QObject::tr("Secret value. Stored locally and masked; screen readers will not read it back.")); } else { input->setAccessibleName(field.label); if (!field.placeholder.isEmpty()) input->setAccessibleDescription(QObject::tr("Example: %1").arg(field.placeholder)); } if (field.required) input->setProperty("required", true); lbl->setBuddy(input); field_widgets[field.name] = input; focus_chain.append(input); form->addWidget(input, row, 1); ++row; } // Tags field auto* tags_lbl = new QLabel(QObject::tr("Tags")); tags_lbl->setAlignment(Qt::AlignRight | Qt::AlignVCenter); form->addWidget(tags_lbl, row, 0); auto* tags_edit = new QLineEdit; tags_edit->setPlaceholderText(QObject::tr("Comma-separated tags, e.g. prod, live, trading")); tags_edit->setFixedHeight(34); tags_edit->setText(existing_loaded ? existing.tags : ""); tags_edit->setAccessibleName(QObject::tr("Tags")); tags_lbl->setBuddy(tags_edit); focus_chain.append(tags_edit); form->addWidget(tags_edit, row, 1); ++row; body_vl->addLayout(form); auto* note = new QLabel(QObject::tr("Fields marked with * are required.")); note->setWordWrap(true); note->setStyleSheet( QString("color:%1;font-size:11px;font-style:italic;background:transparent;").arg(col::TEXT_TERTIARY())); body_vl->addWidget(note); if (has_secret_field) { // Be explicit about where the secret goes — the connection store is a // local SQLite table, not an encrypted keychain, and EXPORT can carry // these values off the machine. auto* secret_note = new QLabel( QObject::tr("Secrets are saved to the local connection database on this machine. " "EXPORT blanks them out unless you explicitly choose to include them.")); secret_note->setWordWrap(true); secret_note->setStyleSheet( QString("color:%1;font-size:11px;background:transparent;").arg(col::WARNING())); body_vl->addWidget(secret_note); } body_vl->addStretch(); scroll->setWidget(body); root_vl->addWidget(scroll, 1); // Dialog footer auto* footer = new QWidget(&dlg); footer->setFixedHeight(54); footer->setStyleSheet(QString("background:%1;border-top:1px solid %2;").arg(col::BG_RAISED(), col::BORDER_DIM())); auto* footer_hl = new QHBoxLayout(footer); footer_hl->setContentsMargins(16, 0, 16, 0); footer_hl->setSpacing(8); auto* status = new QLabel; status->setStyleSheet(QString("color:%1;font-size:12px;background:transparent;").arg(col::TEXT_SECONDARY())); footer_hl->addWidget(status, 1); auto* cancel = new QPushButton(QObject::tr("Cancel")); cancel->setCursor(Qt::PointingHandCursor); cancel->setAccessibleName(QObject::tr("Cancel")); // QDialog already maps Esc to reject() cancel->setStyleSheet(QString("QPushButton{background:%1;color:%2;border:1px solid %3;}" "QPushButton:hover{background:%3;color:%4;}") .arg(col::BG_BASE(), col::TEXT_SECONDARY(), col::BORDER_MED(), col::TEXT_PRIMARY())); footer_hl->addWidget(cancel); auto* save = new QPushButton(editing ? QObject::tr("Update Connection") : QObject::tr("Save Connection")); save->setCursor(Qt::PointingHandCursor); save->setDefault(true); save->setAutoDefault(true); save->setAccessibleName(editing ? QObject::tr("Update connection") : QObject::tr("Save connection")); save->setStyleSheet(QString("QPushButton{background:rgba(217,119,6,0.12);color:%1;border:1px solid %2;}" "QPushButton:hover{background:%1;color:%3;}") .arg(col::AMBER(), col::AMBER_DIM(), col::BG_BASE())); footer_hl->addWidget(save); root_vl->addWidget(footer); // Explicit tab order: every form field in visual order, then Save, then // Cancel. Without this, Qt walks creation order and jumps from the name // field straight into the footer. focus_chain.append(save); focus_chain.append(cancel); for (int i = 0; i + 1 < focus_chain.size(); ++i) QWidget::setTabOrder(focus_chain[i], focus_chain[i + 1]); name_edit->setFocus(); QObject::connect(cancel, &QPushButton::clicked, &dlg, &QDialog::reject); QObject::connect(save, &QPushButton::clicked, &dlg, [&, existing_loaded]() { QJsonObject cfg_json; for (const auto& field : config.fields) { QWidget* widget = field_widgets.value(field.name, nullptr); QString text_value; if (auto* line_edit = qobject_cast(widget)) { text_value = line_edit->text().trimmed(); if (field.type == FieldType::Number) cfg_json[field.name] = text_value.toInt(); else cfg_json[field.name] = text_value; } else if (auto* text_edit = qobject_cast(widget)) { text_value = text_edit->toPlainText().trimmed(); cfg_json[field.name] = text_value; } else if (auto* combo = qobject_cast(widget)) { text_value = combo->currentData().toString(); cfg_json[field.name] = text_value; } else if (auto* check = qobject_cast(widget)) { cfg_json[field.name] = check->isChecked(); } if (field.required && field.type != FieldType::Checkbox && text_value.isEmpty()) { status->setText(QObject::tr("Missing required field: %1").arg(field.label)); status->setStyleSheet( QString("color:%1;font-size:12px;font-weight:700;background:transparent;").arg(col::NEGATIVE())); if (widget) // put the caret where the problem is instead of just naming it widget->setFocus(Qt::OtherFocusReason); return; } } DataSource ds = (existing_loaded && !duplicate) ? existing : DataSource{}; ds.id = (existing_loaded && !duplicate) ? existing.id : QUuid::createUuid().toString(QUuid::WithoutBraces); ds.alias = (existing_loaded && !duplicate) && !existing.alias.isEmpty() ? existing.alias : (config.id + "_" + ds.id.left(8)); ds.display_name = name_edit->text().trimmed().isEmpty() ? config.name : name_edit->text().trimmed(); ds.description = config.description; ds.type = persistence_type(config); ds.provider = config.id; ds.category = category_str(config.category); ds.config = QJsonDocument(cfg_json).toJson(QJsonDocument::Compact); ds.enabled = enabled_check->isChecked(); ds.tags = tags_edit->text().trimmed(); const auto result = DataSourceRepository::instance().save(ds); if (result.is_err()) { status->setText(QObject::tr("Failed to save: %1").arg(QString::fromStdString(result.error()))); status->setStyleSheet( QString("color:%1;font-size:12px;font-weight:700;background:transparent;").arg(col::NEGATIVE())); return; } saved_id = ds.id; dlg.accept(); }); if (dlg.exec() == QDialog::Accepted) return saved_id; return {}; } } // namespace fincept::screens::datasources